Skip to content

Backport of [API Gateway] Turn down controller log levels into release/1.15.x#16352

Merged
hc-github-team-consul-core merged 1 commit intorelease/1.15.xfrom
backport/api-gateway-trace-logs/strongly-enhanced-cow
Feb 22, 2023
Merged

Backport of [API Gateway] Turn down controller log levels into release/1.15.x#16352
hc-github-team-consul-core merged 1 commit intorelease/1.15.xfrom
backport/api-gateway-trace-logs/strongly-enhanced-cow

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16348 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

This turns down all of our controller debug logs to trace logs to avoid too much spam. Additionally, all controller Error logs are moved to Warn level since:

  1. previously Error would be logged for things like a failed reconciliation due to a CAS mismatch, which could just occur with high volumes of writes to a corresponding ConfigEntry
  2. we wind up rescheduling the reconciliation when an error is encountered anyway, so this may or may not be a trivial error that gets resolved next reconciliation run.

Accordingly, it's probably more of a "warning" level than something we'd want to alert the user on at the "error" level.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/api-gateway-trace-logs/strongly-enhanced-cow branch from 84fc232 to c1d9d80 Compare February 22, 2023 02:42
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 9f29e0c into release/1.15.x Feb 22, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/api-gateway-trace-logs/strongly-enhanced-cow branch February 22, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants