Backport of Fix infinite recursion in inline-certificate config entry into release/1.15.x#16281
Merged
hc-github-team-consul-core merged 4 commits intorelease/1.15.xfrom Feb 15, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/infinite-recursion/ideally-selected-martin
branch
from
e684fd7 to
d5ed15e
Compare
github-team-consul-core-pr-approver
approved these changes
Feb 15, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
hc-github-team-consul-core
deleted the
backport/infinite-recursion/ideally-selected-martin
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16276 to be assessed for backporting due to the inclusion of the label backport/1.15.
The below text is copied from the body of the original PR.
Co-Authored-By: Andrew Stucki 3577250+andrewstucki@users.noreply.github.com
Description
GetNamespace()+GetMeta()were calling themselves. This PR also formats similar functions to match our config entries.Testing & Reproduction steps
Links
PR Checklist
Overview of commits