Skip to content

Backport xDS performance fix to 1.13.x#16269

Merged
boxofrad merged 2 commits intorelease/1.13.xfrom
boxofrad/backport-deep-copy
Feb 15, 2023
Merged

Backport xDS performance fix to 1.13.x#16269
boxofrad merged 2 commits intorelease/1.13.xfrom
boxofrad/backport-deep-copy

Conversation

@boxofrad
Copy link
Contributor

Description

Backport #14934 to the 1.13.x release series, to fix a high CPU usage report from a customer on this version.

Backport of #14934 to 1.13 release series.

Replaces the reflection-based implementation of proxycfg's
ConfigSnapshot.Clone with code generated by deep-copy.
@boxofrad boxofrad requested a review from david-yu February 15, 2023 11:07
@github-actions github-actions bot added the type/ci Relating to continuous integration (CI) tooling for testing or releases label Feb 15, 2023
@boxofrad boxofrad requested review from a team and DanStough and removed request for a team February 15, 2023 11:08
Copy link
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the original PR. It just needs the changelog attached.

@boxofrad boxofrad merged commit fde869c into release/1.13.x Feb 15, 2023
@boxofrad boxofrad deleted the boxofrad/backport-deep-copy branch February 15, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/ci Relating to continuous integration (CI) tooling for testing or releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants