proxycfg: init WatchedLocalGWEndpoints map for Ingress and API gateways#16238
Closed
mikemorris wants to merge 1 commit intomainfrom
Closed
proxycfg: init WatchedLocalGWEndpoints map for Ingress and API gateways#16238mikemorris wants to merge 1 commit intomainfrom
mikemorris wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Initialize the
WatchedLocalGWEndpointssnapshot map for Ingress and API gateways.Testing & Reproduction steps
We don't support setting peer upstreams on Ingress gateways yet, but if an ingress has been configured to point to a service with a cross-peer failover configured, a watch may be attempted to be set up on the local mesh gateway at https://github.com/hashicorp/consul-enterprise/blob/main/agent/proxycfg/upstreams.go#L345, resulting in a panic when https://github.com/hashicorp/consul-enterprise/blob/main/agent/proxycfg/upstreams.go#L622 is called because the map has not been initialized.
This needs testing and this area of the codebase could likely benefit from a panic handler to avoid errors like this from bringing down the server in a state from which it can be difficult to recover.
PR Checklist