Backport of command: Fix logger not initializing properly in envoy command into release/1.13.x#16152
Closed
hc-github-team-consul-core wants to merge 2 commits intorelease/1.13.xfrom
Conversation
hc-github-team-consul-core
force-pushed
the
backport/envoy-bootstrap-log-fix/infinitely-communal-midge
branch
from
decf008 to
ffd4fe7
Compare
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
github-team-consul-core-pr-approver
approved these changes
Feb 3, 2023
Collaborator
github-team-consul-core-pr-approver
left a comment
github-team-consul-core-pr-approver
left a comment
There was a problem hiding this comment.
Auto approved Consul Bot automated PR
github-actions
bot
deleted the
backport/envoy-bootstrap-log-fix/infinitely-communal-midge
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16148 to be assessed for backporting due to the inclusion of the label backport/1.13.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Follow up to (#15988). Caught this when backporting - the logger is getting set up in the wrong place (before flags are parsed) so it won't get set to debug properly when the flag is passed in.
Overview of commits