Closed
Conversation
github-actions
bot
added
the
type/docs
Contributor
trujillo-adam
left a comment
trujillo-adam
left a comment
There was a problem hiding this comment.
Looks good. I just have a few changes for consistency with our style guide.
| $ export VERSION=1.0 && \ | ||
| curl --location "https://releases.hashicorp.com/consul-k8s/${VERSION}/consul-k8s_${VERSION}_darwin_amd64.zip" --output consul-k8s-cli.zip | ||
| $ export VERSION=0.49.0 && \ | ||
| curl -L "https://releases.hashicorp.com/consul-k8s/${VERSION}/consul-k8s_${VERSION}_darwin_$( [ $(uname -m) = aarch64 ] && echo arm64 || echo amd64).zip" -o consul-k8s-cli.zip |
Contributor
There was a problem hiding this comment.
Suggested change
| curl -L "https://releases.hashicorp.com/consul-k8s/${VERSION}/consul-k8s_${VERSION}_darwin_$( [ $(uname -m) = aarch64 ] && echo arm64 || echo amd64).zip" -o consul-k8s-cli.zip | |
| curl --location "https://releases.hashicorp.com/consul-k8s/${VERSION}/consul-k8s_${VERSION}_darwin_$( [ $(uname -m) = aarch64 ] && echo arm64 || echo amd64).zip" --output consul-k8s-cli.zip |
Per the style guide, we should use the long flag name.
| After installing the Consul K8s CLI tool (`consul-k8s`), issue the `install` subcommand and any additional options to install Consul on Kubernetes. | ||
| Refer to the [Consul K8s CLI reference](/docs/k8s/k8s-cli) for details about all commands and available options. | ||
| If you do not include any additional options, the `consul-k8s` CLI installs Consul on Kubernetes using the default settings form the Consul Helm chart values. | ||
| The following example installs Consul on Kubernetes with Service Mesh and CRDs enabled with the `quickstart` preset. If you are using `consul-k8s` < 1.0.0 use the `demo` preset instead. |
Contributor
There was a problem hiding this comment.
Suggested change
| The following example installs Consul on Kubernetes with Service Mesh and CRDs enabled with the `quickstart` preset. If you are using `consul-k8s` < 1.0.0 use the `demo` preset instead. | |
| The following example installs Consul on Kubernetes with Service Mesh and CRDs enabled with the `quickstart` preset. If you are using `consul-k8s` 1.0.0 or later, use the `demo` preset instead. |
Per the style guide, don't use mathematical symbols in prose.
|
This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions. |
github-actions
bot
added
the
meta/stale
|
Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Consul-K8S with version 1.0.0 has introduced some changes, and his PR incorporates those changes.
Links
hashicorp/consul-k8s#1755
PR Checklist