Backport of Detect Vault 1.11+ import, update default issuer into release/1.13.x #15430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/fix-issuer-growing-list-maybe-from-vault/uniquely-master-falcon
branch
from
7cc4ac0 to
eb217f5
Compare
hc-github-team-consul-core
force-pushed
the
backport/fix-issuer-growing-list-maybe-from-vault/uniquely-master-falcon
branch
from
df5c4d9 to
d626212
Compare
github-actions
bot
added
the
theme/connect
|
Closed in favor of #15436 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15253 to be assessed for backporting due to the inclusion of the label backport/1.13.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Signed-off-by: Alexander Scheel <[email protected]>Description
Background: https://support.hashicorp.com/hc/en-us/articles/11308460105491
Consul used to rely on implicit issuer selection when calling Vault endpoints to issue new CSRs. Vault 1.11+ changed that behavior, which caused Consul to check the wrong (previous) issuer when renewing its Intermediate CA. This patch allows Consul to explicitly set a default issuer when it detects that the response from Vault is 1.11+.
Testing & Reproduction steps
Links
https://support.hashicorp.com/hc/en-us/articles/11308460105491
Vault's PR to add multiple issuer support in PKI: hashicorp/vault#15277
Vault's PR to add flag to opt-in to previous behavior: hashicorp/vault#17824
PR Checklist
Overview of commits