docs: update k8s vault connect ca config docs#14221
Merged
jkirschner-hashicorp merged 1 commit intomainfrom Aug 23, 2022
Merged
docs: update k8s vault connect ca config docs#14221jkirschner-hashicorp merged 1 commit intomainfrom
jkirschner-hashicorp merged 1 commit intomainfrom
Conversation
Contributor
jkirschner-hashicorp
commented
Aug 16, 2022
jkirschner-hashicorp
commented
- Add namespace to additionalConfig example
- Improve the link to additional configuration options available
jkirschner-hashicorp
added
type/docs
david-yu
approved these changes
Aug 16, 2022
Contributor
|
This can be merged, but these docs are actually autogenerated so we need to make the same changes to values.yaml, otherwise these changes will be lost upon the next k8s release. |
Contributor
Author
jkirschner-hashicorp
left a comment
jkirschner-hashicorp
left a comment
There was a problem hiding this comment.
Two copy/paste things to fix
jkirschner-hashicorp
added
the
pr/no-changelog
Contributor
Author
|
@david-yu : ah - I had no idea! When are the auto-generated updates made? I want to fix in the auto-gen source before this gets merged ... otherwise it's easy to lose track of. |
Contributor
|
Here is the corresponding PR: hashicorp/consul-k8s#1430 |
Merged
2 tasks
- Add namespace to additionalConfig example - Improve the link to additional configuration options available
jkirschner-hashicorp
force-pushed
the
jkirschner-hashicorp-patch-1
branch
from
3c2d280 to
4f92061
Compare
This was referenced Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.