Merged
Conversation
Updates k8s annotation docs for the options added in hashicorp/consul-k8s#1315.
github-actions
bot
added
the
type/docs
boruszak
approved these changes
Jul 21, 2022
Contributor
boruszak
left a comment
boruszak
left a comment
There was a problem hiding this comment.
Overall LGTM to me with these minor suggestions.
Please let me know if you have any questions or need any further assistance!
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Contributor
|
I added some more detail here about how to populate the actual values for this annotation, as it is not very apparent on how to do based on the description that was provided. |
david-yu
changed the title
david-yu
approved these changes
Jul 22, 2022
This was referenced Jul 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates k8s annotation docs for the options added in hashicorp/consul-k8s#1315.
Description
Describe why you're making this change, in plain English.
Testing & Reproduction steps
Links
Include any links here that might be helpful for people reviewing your PR (Tickets, GH issues, API docs, external benchmarks, tools docs, etc). If there are none, feel free to delete this section.
Please be mindful not to leak any customer or confidential information. HashiCorp employees may want to use our internal URL shortener to obfuscate links.
PR Checklist