Skip to content

WIP: Experiment with language around Consul's connect subsystem#12486

Closed
jkirschner-hashicorp wants to merge 1 commit intomainfrom
docs/clarify-connect-language
Closed

WIP: Experiment with language around Consul's connect subsystem#12486
jkirschner-hashicorp wants to merge 1 commit intomainfrom
docs/clarify-connect-language

Conversation

@jkirschner-hashicorp
Copy link
Contributor

@jkirschner-hashicorp jkirschner-hashicorp commented Mar 2, 2022

No description provided.

@jkirschner-hashicorp jkirschner-hashicorp added the pr/do-not-merge PR cannot be merged in its current form. label Mar 2, 2022
@jkirschner-hashicorp jkirschner-hashicorp requested a review from a team as a code owner March 2, 2022 00:34
@jkirschner-hashicorp jkirschner-hashicorp marked this pull request as draft March 2, 2022 00:35
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Mar 2, 2022
@hashicorp-ci
Copy link
Contributor

hashicorp-ci commented Mar 2, 2022

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@jkirschner-hashicorp jkirschner-hashicorp changed the title WIP: Clarify language around Consul's connect subsystem WIP: Experiment with language around Consul's connect subsystem Mar 2, 2022
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented May 13, 2022

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label May 13, 2022
@github-actions
Copy link

github-actions bot commented Jun 13, 2022

Closing due to inactivity. If you feel this was a mistake or you wish to re-open at any time in the future, please leave a comment and it will be re-surfaced for the maintainers to review.

@github-actions github-actions bot closed this Jun 13, 2022
@david-yu
Copy link
Contributor

david-yu commented Jun 14, 2022

Nice I like what I see here @jkirschner-hashicorp

@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Jun 14, 2022
johncowen
johncowen reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was driving by and spotted a tinsy typo

website/content/commands/connect/expose.mdx

Exposes a Connect-enabled service through the given ingress gateway, using the
given protocol and port.
Exposes a service in the service meshthrough the given ingress gateway,
Copy link
Contributor

@johncowen johncowen Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Exposes a service in the service meshthrough the given ingress gateway,
Exposes a service in the service mesh through the given ingress gateway,

@david-yu
Copy link
Contributor

david-yu commented Jun 20, 2022

Could we re-open, re-base and get feedback on just the portions that require no code changes?

@jkirschner-hashicorp
Copy link
Contributor Author

jkirschner-hashicorp commented Jun 21, 2022

@david-yu : I need to get alignment on approach internally before applying more broadly. I can use what I have shown here to get feedback. I'll take this up in a few weeks.

@github-actions
Copy link

github-actions bot commented Aug 23, 2022

This pull request has been automatically flagged for inactivity because it has not been acted upon in the last 60 days. It will be closed if no new activity occurs in the next 30 days. Please feel free to re-open to resurrect the change if you feel this has happened by mistake. Thank you for your contributions.

@github-actions github-actions bot added the meta/stale Automatically flagged for inactivity by stalebot label Aug 23, 2022
@jkirschner-hashicorp jkirschner-hashicorp added the meta/staleproof Exempt from stalebot automation label Aug 23, 2022
@github-actions github-actions bot removed the meta/stale Automatically flagged for inactivity by stalebot label Aug 24, 2022
@jkirschner-hashicorp
Copy link
Contributor Author

jkirschner-hashicorp commented May 4, 2023

Replaced by #17222

@github-actions github-actions bot deleted the docs/clarify-connect-language branch August 29, 2025 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@johncowen johncowen johncowen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta/staleproof Exempt from stalebot automation pr/do-not-merge PR cannot be merged in its current form. type/docs Documentation needs to be created/updated/clarified

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jkirschner-hashicorp @hashicorp-ci @hashicorp-cla @david-yu @johncowen