Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDX-205 add netcgo tag for darwin builds #12178

Merged
merged 1 commit into from
Jan 25, 2022
Merged

RDX-205 add netcgo tag for darwin builds #12178

merged 1 commit into from
Jan 25, 2022

Conversation

modrake
Copy link
Contributor

@modrake modrake commented Jan 24, 2022 •
edited
Loading

This adds the "netcgo" tag to darwin builds to resolve a longstanding issue with DNS on mac binaries.

@modrake modrake added backport/1.8 pr/no-changelog PR does not need a corresponding .changelog entry labels Jan 24, 2022
@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Jan 24, 2022
@alvin-huang alvin-huang requested a review from a team January 24, 2022 22:48
@kisunji
Copy link
Contributor

kisunji commented Jan 25, 2022

Could you give us a link to a related issue? Googling led me to golang/go#31705 but it's a few years old

@modrake
Copy link
Contributor Author

modrake commented Jan 25, 2022

Could you give us a link to a related issue? Googling led me to golang/go#31705 but it's a few years old

https://hashicorp.atlassian.net/browse/RDX-205 has details as well as a link to the detailed RFC that releng performed when this first became a known issue. We were unable to address it previously due to the limitations of circleci's mac builders.

smacfarlane
smacfarlane approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@smacfarlane smacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This change looks good from RelEng's perspective.

smacfarlane
smacfarlane approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@smacfarlane smacfarlane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong tab

@modrake modrake merged commit 64e9e8a into main Jan 25, 2022
@modrake modrake deleted the RDX-205-add-netcgo-for-darwin-builds branch January 25, 2022 22:10
@hc-github-team-consul-core
Copy link
Collaborator

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/565175.

@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 64e9e8a onto release/1.11.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 25, 2022
@modrake @hc-github-team-consul-core
Merge pull request #12178 from hashicorp/RDX-205-add-netcgo-for-darwi…
4d722b5 
…n-builds

RDX-205 add netcgo tag for darwin builds
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 64e9e8a onto release/1.10.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 25, 2022
@modrake @hc-github-team-consul-core
Merge pull request #12178 from hashicorp/RDX-205-add-netcgo-for-darwi…
ac05ecc 
…n-builds

RDX-205 add netcgo tag for darwin builds
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 64e9e8a onto release/1.9.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 25, 2022
@modrake @hc-github-team-consul-core
Merge pull request #12178 from hashicorp/RDX-205-add-netcgo-for-darwi…
1257839 
…n-builds

RDX-205 add netcgo tag for darwin builds
@hc-github-team-consul-core
Copy link
Collaborator

🍒✅ Cherry pick of commit 64e9e8a onto release/1.8.x succeeded!

hc-github-team-consul-core pushed a commit that referenced this pull request Jan 25, 2022
@modrake @hc-github-team-consul-core
Merge pull request #12178 from hashicorp/RDX-205-add-netcgo-for-darwi…
c728d4e 
…n-builds

RDX-205 add netcgo tag for darwin builds
@mikemorris
Copy link
Contributor

Fixes #3267

@mdeggies mdeggies mentioned this pull request Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisunji kisunji kisunji approved these changes

@smacfarlane smacfarlane smacfarlane approved these changes

@samsalisbury samsalisbury Awaiting requested review from samsalisbury

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@modrake @kisunji @hc-github-team-consul-core @mikemorris @smacfarlane