Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: test against Go1.16.3 #10004

Merged
merged 3 commits into from
Apr 16, 2021
Merged

ci: test against Go1.16.3 #10004

merged 3 commits into from
Apr 16, 2021

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Apr 13, 2021

No description provided.

@dnephin dnephin added the pr/no-changelog PR does not need a corresponding .changelog entry label Apr 13, 2021
@dnephin dnephin requested review from mikemorris and a team April 13, 2021 16:20
@github-actions github-actions bot added the type/ci Relating to continuous integration (CI) tooling for testing or releases label Apr 13, 2021
@dnephin
connect: fix test for go1.16
3e20bd2 
There is no way to compare x509.CertPools now that it has an unexpected
function field. This comparison is as close as we can get.

See golang/go#26614 for a related issue.
@dnephin
tlsutil: fix a test for go1.16
bbb9a73 
Using a TestSigner was causing problems because go1.16 has this change:

> CreateCertificate now verifies the generated certificate's signature
> using the signer's public key. If the signature is invalid, an error is
> returned, instead of a malformed certificate.

See https://golang.org/doc/go1.16#crypto/x509
@vercel vercel bot temporarily deployed to Preview – consul April 13, 2021 17:34 Inactive
@vercel vercel bot temporarily deployed to Preview – consul-ui-staging April 13, 2021 17:34 Inactive
@mikemorris mikemorris added this to the 1.10.0 milestone Apr 14, 2021
@mikemorris mikemorris requested a review from a team April 14, 2021 18:01
rboyer
rboyer approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@rboyer rboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnephin dnephin merged commit 3f05e30 into master Apr 16, 2021
@dnephin dnephin deleted the dnephin/go1.16 branch April 16, 2021 17:05
@hashicorp-ci
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/352922.

@dnephin dnephin mentioned this pull request May 3, 2021
Merged
@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/361039.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 3f05e30 onto release/1.10.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/361093.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 3f05e30 onto release/1.10.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/361094.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 3f05e30 onto release/1.10.x failed! Build Log

@hc-github-team-consul-core
Copy link
Contributor

🍒 If backport labels were added before merging, cherry-picking will start automatically.

To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/361095.

@hc-github-team-consul-core
Copy link
Contributor

🍒❌ Cherry pick of commit 3f05e30 onto release/1.10.x failed! Build Log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rboyer rboyer rboyer approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees
No one assigned
Labels
pr/no-changelog PR does not need a corresponding .changelog entry type/ci Relating to continuous integration (CI) tooling for testing or releases
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dnephin @hashicorp-ci @hc-github-team-consul-core @rboyer @mikemorris