Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to terraform-exec v0.17 #969

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Upgrade to terraform-exec v0.17 #969

merged 2 commits into from
Jun 23, 2022

Conversation

lornasong
Copy link
Member

Fixes: #849

Commits:

  • Adds a test to show issue with leaked goroutines (test fails)
  • Pulls latest tf-exec version (test passes)

@lornasong
Add Test_TerraformExec_Leak to check for leaked goroutines in tf-exec
23c4678 
Test does a goroutine check before and after tf-exec is called. Expect this
test to fail because this issue will be resolved in next commit with a version
upgrade

Failure:

```
=== RUN   Test_TerraformExec_Leak
    /Users/lornasong/go/src/github.com/hashicorp/consul-terraform-sync/client/terraform_exec_test.go:60:
        	Error Trace:	terraform_exec_test.go:60
        	Error:      	Not equal:
        	            	expected: 2
        	            	actual  : 6
        	Test:       	Test_TerraformExec_Leak
        	Messages:   	the number of goroutines after the terraform requests should be the same as before
--- FAIL: Test_TerraformExec_Leak (1.36s)
```
@lornasong
Update terraform-exec to v0.17
ba975c6 
This resolves some leaked goroutines with terraform-exec
@lornasong lornasong requested review from a team and mkam and removed request for a team June 23, 2022 19:19
mkam
mkam approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@mkam mkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for putting in all the effort to fix this in terrafrom-exec!

@lornasong lornasong merged commit fa928e2 into main Jun 23, 2022
@lornasong lornasong deleted the tf-exec-0-17 branch June 23, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkam mkam mkam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Terraform CLI requests cause leaked go-routines
2 participants
@lornasong @mkam