Commits on Oct 2, 2024

1. [NET-10985] Fix bug where imagePullSecrets were not set up for Gatewa… …

   …ys (#4316)
   
   * Plumb global.imagePullSecrets through to Gateway's ServiceAccount
   
   Since pull secrets are a list of structured objects that cannot easily be passed as a flag value to the container, this approach uses a JSON config file that is created as a ConfigMap and then mounted into the connect-injector Pod and parsed on startup.
   
   * Leave camp cleaner than I found it
   
   * Make path to config file configurable
   
   * Add changelog entry
   
   * Add note to changelog entry
   
   * Ensure ServiceAccount is created if any image pull secrets are provided
   
   * Add test coverage for image pull secret inclusion on gateway ServiceAccount
   
   * Adjust note in changelog
   
   * Add a helpful comment explaining when/why we create a ServiceAccount
   
   * Update .changelog/4316.txt
   
   Co-authored-by: Blake Covarrubias <[email protected]>
   
   * Return ServiceAccount name when image pull secrets warrant it
   
   * Improve unit tests to assert presence of ServiceAccount name on Deployment
   
   * Copy helpful comment added elsewhere
   
   ---------
   
   Co-authored-by: Blake Covarrubias <[email protected]>

   

   nathancoleman and blake committed Oct 2, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for cbe68bf
   • Browse repository at this point

   Copy the full SHA

   cbe68bf View commit details

   Browse the repository at this point in the history