-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NET-11150] ci: fix conditional skip and add safeguard #4363
Conversation
@@ -12,13 +12,58 @@ jobs: | |||
runs-on: ubuntu-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No updates needed to triggers in calling workflows, as they were already split on PR and protected branch push.
.copywrite.hcl | ||
.gitignore | ||
**.md | ||
assets/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the only changed lines from the original dataplane PR.
20c6e08
to
230cc21
Compare
Adopt a third-party action to avoid script bugs, and to fix a current issue where the script fails to detect all changes when processing push events on PR branches. Adapted from hashicorp/consul-dataplane#637. See that PR for testing details and background context.
230cc21
to
93e8afe
Compare
Adopt a third-party action to avoid script bugs, and to fix a current issue where the script fails to detect all changes when processing push events on PR branches.
Adapted from hashicorp/consul-dataplane#637. See that PR for testing details and background context.
How I've tested this PR
See hashicorp/consul-dataplane#637 and conditional skip output in this PR's checks.
How I expect reviewers to test this PR
👀
Checklist