Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NET-10985] Fix bug where imagePullSecrets were not set up for Gateways #4316

Merged
merged 13 commits into from
Sep 27, 2024
Merged

[NET-10985] Fix bug where imagePullSecrets were not set up for Gateways #4316

merged 13 commits into from
Sep 27, 2024

Commits on Sep 24, 2024

  1. Plumb global.imagePullSecrets through to Gateway's ServiceAccount 

    Since pull secrets are a list of structured objects that cannot easily be passed as a flag value to the container, this approach uses a JSON config file that is created as a ConfigMap and then mounted into the connect-injector Pod and parsed on startup.
    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    25ba129 View commit details
    Browse the repository at this point in the history

  2. Leave camp cleaner than I found it

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    34bbb73 View commit details
    Browse the repository at this point in the history

  3. Make path to config file configurable

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    316985a View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    aa0758f View commit details
    Browse the repository at this point in the history

  5. Add note to changelog entry

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    b7c1824 View commit details
    Browse the repository at this point in the history

  6. Ensure ServiceAccount is created if any image pull secrets are provided

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    76415b8 View commit details
    Browse the repository at this point in the history

  7. Add test coverage for image pull secret inclusion on gateway ServiceA… 

    …ccount
    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    a6b9305 View commit details
    Browse the repository at this point in the history

  8. Adjust note in changelog

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    365b2c2 View commit details
    Browse the repository at this point in the history

  9. Add a helpful comment explaining when/why we create a ServiceAccount

    @nathancoleman
    nathancoleman committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ac64e83 View commit details
    Browse the repository at this point in the history

  10. Update .changelog/4316.txt 

    Co-authored-by: Blake Covarrubias <[email protected]>
    @nathancoleman @blake
    nathancoleman and blake authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e6b636d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Return ServiceAccount name when image pull secrets warrant it

    @nathancoleman
    nathancoleman committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1e3503c View commit details
    Browse the repository at this point in the history

  2. Improve unit tests to assert presence of ServiceAccount name on Deplo… 

    …yment
    @nathancoleman
    nathancoleman committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    8260f94 View commit details
    Browse the repository at this point in the history

  3. Copy helpful comment added elsewhere

    @nathancoleman
    nathancoleman committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    16fceb9 View commit details
    Browse the repository at this point in the history