Skip to content

Backport of Add HOST_IP environment variable to consul_dataplane_sidecar.go into release/1.4.x#4284

Merged
nathancoleman merged 7 commits intorelease/1.4.xfrom
backport/woz5999/sidecar-host-ip/moderately-super-lemming
Aug 30, 2024
Merged

Backport of Add HOST_IP environment variable to consul_dataplane_sidecar.go into release/1.4.x#4284
nathancoleman merged 7 commits intorelease/1.4.xfrom
backport/woz5999/sidecar-host-ip/moderately-super-lemming

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Aug 30, 2024

Backport

This PR is auto-generated from #4277 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Note

This is sourced from #3916. I needed to open here so that CI requiring tokens that are unavailable in forks can run

Changes proposed in this PR

  • Add HOST_IP environment variable to consul_dataplane_sidecar.go

This environment variable must be set in order to utilize HOST_IP as part of statsd or dogstatsd sinks. If this variable is unset and the sink is configured to use HOST_IP, the sidecar won't start and pods won't come up healthy.

How I've tested this PR

  • Unit tests
  • Deployed and tested a local build to our cluster and confirmed that injected pods now come up healthy and have the HOST_IP variable set as expected

How I expect reviewers to test this PR

  • The unit tests should do it

    Reference to similar change for mesh-gateway deployments:

Checklist


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/woz5999/sidecar-host-ip/moderately-super-lemming branch from 48f962e to d760cb0 Compare August 30, 2024 17:25
@nathancoleman nathancoleman marked this pull request as ready for review August 30, 2024 20:39
@nathancoleman nathancoleman force-pushed the backport/woz5999/sidecar-host-ip/moderately-super-lemming branch from d760cb0 to 08996a4 Compare August 30, 2024 20:41
@nathancoleman nathancoleman enabled auto-merge (squash) August 30, 2024 20:44
@nathancoleman nathancoleman merged commit e1509ce into release/1.4.x Aug 30, 2024
@nathancoleman nathancoleman deleted the backport/woz5999/sidecar-host-ip/moderately-super-lemming branch August 30, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants