Backport of Add HOST_IP environment variable to consul_dataplane_sidecar.go into release/1.1.x#4282
Open
hc-github-team-consul-core wants to merge 5 commits intorelease/1.1.xfrom
Conversation
55e80ee to
a2f64cb
Compare
a2f64cb to
eb8a962
Compare
nathancoleman
approved these changes
Aug 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #4277 to be assessed for backporting due to the inclusion of the label backport/1.1.x.
The below text is copied from the body of the original PR.
Note
This is sourced from #3916. I needed to open here so that CI requiring tokens that are unavailable in forks can run
Changes proposed in this PR
HOST_IPenvironment variable to consul_dataplane_sidecar.goThis environment variable must be set in order to utilize
HOST_IPas part of statsd or dogstatsd sinks. If this variable is unset and the sink is configured to useHOST_IP, the sidecar won't start and pods won't come up healthy.How I've tested this PR
HOST_IPvariable set as expectedHow I expect reviewers to test this PR
The unit tests should do it
Reference to similar change for mesh-gateway deployments:
consul-k8s/CHANGELOG.md
Line 763 in 8ac97bf
Checklist
Overview of commits