[NET-9932] Always add NET_BIND_SERVICE capability to injected sidecar container#4066
Closed
nathancoleman wants to merge 3 commits intomainfrom
Closed
[NET-9932] Always add NET_BIND_SERVICE capability to injected sidecar container#4066nathancoleman wants to merge 3 commits intomainfrom
nathancoleman wants to merge 3 commits intomainfrom
Conversation
e0d4d94 to
531db20
Compare
Member
Author
|
Note to self: This PR cannot be backported to any release that requires running Consul w/ the pods "backend-6c4cf7dc55-" is forbidden: unable to validate against any security context constraint:
| [provider anyuid: .containers[0].capabilities.add:
│ Invalid value: "NET_BIND_SERVICE": capability may not be added |
missylbytes
added a commit
that referenced
this pull request
Jun 26, 2024
missylbytes
added a commit
that referenced
this pull request
Jun 26, 2024
2 tasks
This was referenced Jul 9, 2024
Member
Author
|
This change happened in #4152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
Consul-dataplane always requires the
NET_BIND_SERVICEcapability (docs). This is explicitly allowed under therestricted-v2SecurityContextConstraints(SCC) that ships with OpenShift 4.11+; however, the container needs to request the capability in order for it to be granted. This change does that.How I've tested this PR
Worked w/ @natemollica-nm to verify that this fix allows the application sidecar running the
consul-dataplaneimage to spin up successfully under therestricted-v2SCC where it would have previously logged the following error on startup.Application sidecars should now be fully functional on OpenShift without creating a custom SCC.
The
Podcontaining the injected sidecar should get an annotation from OpenShift indicating that it's using therestricted-v2SCC.How I expect reviewers to test this PR
See above
Checklist