[NET-9097] Update service resolver webhook registration missed in previous backport#4008
Merged
nathancoleman merged 1 commit intorelease/1.2.xfrom May 20, 2024
Conversation
nathancoleman
added
pr/no-changelog
jm96441n
approved these changes
May 20, 2024
nathancoleman
deleted the
backport/controller-runtime/enormously-liberal-mammal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
There was a slight oversight in #3967 in which the
ServiceResolverwebhook registration wasn't updated to use the newSetupWithManager()pattern like all of the other webhooks were. This PR updates it.The result was that the manager would never have a decoder assigned to it. This was previously implicitly done by controller-runtime but was removed, thus the introduction of
SetupWithManager()on all of the webhooks.How I've tested this PR
🤖 tests pass
How I expect reviewers to test this PR
Checklist