Skip to content

[NET-9153] Handle Terminating Gateway ACL Setup #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jm96441n merged 16 commits into from
May 13, 2024
Merged

[NET-9153] Handle Terminating Gateway ACL Setup #3975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
2df5566
first pass at creating write policy for service and updating term gw acl
jm96441n May 6, 2024
0a8e9b8
handle deregistering, update tests for registering with acls
jm96441n May 7, 2024
3556f85
existing deregister tests passing
jm96441n May 7, 2024
74603ca
failures with term gw role not existing
jm96441n May 7, 2024
fc09192
clean up
jm96441n May 8, 2024
015353e
reorg code
jm96441n May 8, 2024
ed4ae69
Move to own package
jm96441n May 8, 2024
391148f
watch for terminating gateways
jm96441n May 8, 2024
adde44b
move files back, handle multiple terminating gateways
jm96441n May 9, 2024
28cfb1b
handle errors and ensure finalizer is set
jm96441n May 9, 2024
629e68a
Add tests for finalizers
jm96441n May 9, 2024
7beb433
Merge branch 'main' into NET-9513-create-term-gw-acl-role
jm96441n May 9, 2024
97a4323
remove unused file
jm96441n May 9, 2024
677a728
fix import naming
jm96441n May 9, 2024
f6ca32b
linting
jm96441n May 10, 2024
9086e37
fix comment, extract constant
jm96441n May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions control-plane/api/v1alpha1/registration_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
)

func init() {
Expand Down Expand Up @@ -289,6 +290,13 @@ func (r *Registration) ToCatalogDeregistration() *capi.CatalogDeregistration {
}
}

func (r *Registration) NamespacedName() types.NamespacedName {
return types.NamespacedName{
Namespace: r.Namespace,
Name: r.Name,
}
}

// SetSyncedCondition sets the synced condition on the Registration.
func (r *Registration) SetSyncedCondition(status corev1.ConditionStatus, reason string, message string) {
r.Status.Conditions = Conditions{
Expand Down
Loading