Backport of [NET-6466] Remove secrets from termgw role into release/1.3.x#3946
Merged
jm96441n merged 5 commits intorelease/1.3.xfrom Apr 23, 2024
Conversation
282e58b to
cf35c93
Compare
…secrets-for-termgw/internally-deep-guinea
jm96441n
approved these changes
Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3928 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
🚨
The person who merged in the original PR is:
@jm96441n
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR
How I've tested this PR
make dev-dockerfrom the root of this repostart.shreplace the value forCONSUL_K8S_CHART_LOCATIONwith the path to the helm charts in consul-k8s on your systemstart.shcurlonto the container usingapk add curlcurl zoidberg.virtual.consulHow I expect reviewers to test this PR
Read the code, follow the above steps
Checklist
Overview of commits