Helm: fix hardcoded datadog ad url#3877
Closed
dgdelahera wants to merge 2 commits intohashicorp:mainfrom
Closed
Conversation
added 2 commits
April 4, 2024 12:10
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
dgdelahera
changed the title
Author
|
I'm unable to sign the CLA: 
|
Contributor
|
Hi @dgdelahera We have a PR in the works that should resolve this! #3685 Thanks for filing. We'll resolve your issue when that PR is closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
Result can be checked in the test. Now the ad URL will always point to the correct server service name.
How I expect reviewers to test this PR
Checklist