Skip to content

Helm: support sync-lb-services-endpoints for sync catalog#3875

Closed
jukie wants to merge 4 commits intohashicorp:mainfrom
jukie:feat/helm-support-sync-lb-services-endpoints
Closed

Helm: support sync-lb-services-endpoints for sync catalog#3875
jukie wants to merge 4 commits intohashicorp:mainfrom
jukie:feat/helm-support-sync-lb-services-endpoints

Conversation

@jukie
Copy link
Copy Markdown
Contributor

@jukie jukie commented Apr 4, 2024

Changes proposed in this PR

  • syncCatalog: add support for sync-lb-services-endpoints startup flag

How I've tested this PR

helm template

How I expect reviewers to test this PR

Validate that if the helm value is set to true that it's correctly rendered in the deployment manifest

Checklist

fixes #3899

@zalimeni
Copy link
Copy Markdown
Member

Hey @jukie , thanks so much for this contribution! I noticed a small bug in the order of template tags and also wanted to add a test, so I've opened #3905 to do that as well as run privileged tests. If it's alright with you, I'll get that PR approved and merge, then close this one.

@jukie
Copy link
Copy Markdown
Contributor Author

jukie commented Apr 12, 2024

Awesome, sounds great! I can see that's merged so will close this.

@jukie jukie closed this Apr 12, 2024
@jukie jukie deleted the feat/helm-support-sync-lb-services-endpoints branch April 30, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm: support sync-lb-services-endpoints for Sync Catalog

2 participants