Skip to content

Backport of NET-6878: Remove finalizers from CRDs during test resource cleanup into release/1.1.x#3746

Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.1.xfrom
backport/cleanup_remove_finalizers/adversely-worthy-buffalo
Closed

Backport of NET-6878: Remove finalizers from CRDs during test resource cleanup into release/1.1.x#3746
hc-github-team-consul-core wants to merge 1 commit intorelease/1.1.xfrom
backport/cleanup_remove_finalizers/adversely-worthy-buffalo

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #3739 to be assessed for backporting due to the inclusion of the label backport/1.1.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@NiniOak
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Changes proposed in this PR

At times, CRDs created as part of the test suite are not cleaned up properly causing the test to timeout and run for a really long time

  • Switch from retrier based on time to a counter based retries for fast fail
  • Add goroutine to the remove finalizers, if "delete" resource command is called

How I've tested this PR

CI should pass

How I expect reviewers to test this PR

CI should pass

Checklist


Overview of commits

@hashicorp-cla
Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@NiniOak NiniOak closed this Mar 14, 2024
@github-actions github-actions bot deleted the backport/cleanup_remove_finalizers/adversely-worthy-buffalo branch September 1, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants