Backport of fix(control-plane): acl tokens deleted while pods in graceful shutdown into release/1.2.x#3743
Merged
DanStough merged 2 commits intorelease/1.2.xfrom Mar 20, 2024
Conversation
3eab26e to
7e4d49c
Compare
fd2625f to
ec361f3
Compare
Contributor
|
@ndhanushkodi would you remind reviewing the second commit of this PR where we working on the test fix yesterday. Once you give the 👍 I will come back around to the later release branches and make a PR just for the test fix. |
DanStough
reviewed
Mar 19, 2024
2 tasks
fd0f726 to
87843dd
Compare
ndhanushkodi
approved these changes
Mar 19, 2024
Contributor
ndhanushkodi
left a comment
There was a problem hiding this comment.
The second commit looks good, just two non-blocking questions
87843dd to
a02dfea
Compare
a02dfea to
aa76040
Compare
This was referenced Mar 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3736 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
🚨
The person who merged in the original PR is:
@DanStough
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
👀 ☕
Checklist
Overview of commits