Backport of [NET-2420] security: re-enable security scan release block into release/1.3.x#3650
Merged
zalimeni merged 2 commits intorelease/1.3.xfrom Feb 21, 2024
Conversation
|
|
zalimeni
force-pushed
the
backport/zalimeni/net-2420-reenable-security-scans-k8s/nationally-saving-lionfish
branch
from
36e8b8b to
9777914
Compare
This was previously disabled due to an unresolved false-positive CVE. Re-enabling both secrets and OSV + Go Modules scanning, which per our current scan results should not be a blocker to future releases. Also add security scans on PR and merge to protected branches to allow proactive triage going forward. See hashicorp/consul#19978 for similar change in that repo, adapted here.
Triage this scan result as `consul-k8s` should not be directly impacted and it is medium severity. Follow-up ticket filed for remediation. Also improve formatting of scan config since this change will be backported.
zalimeni
force-pushed
the
backport/zalimeni/net-2420-reenable-security-scans-k8s/nationally-saving-lionfish
branch
from
c6a8ce9 to
af0d217
Compare
2 tasks
zalimeni
approved these changes
Feb 21, 2024
zalimeni
deleted the
backport/zalimeni/net-2420-reenable-security-scans-k8s/nationally-saving-lionfish
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #3628 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
🚨
The person who merged in the original PR is:
@zalimeni
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Follow-up to #3625 to re-enable scans.
Changes proposed in this PR
mainandrelease/**Scanner config is intentionally aligned w/ changes made in hashicorp/consul#19978 for consistency.
How I've tested this PR
CI continues to pass, scan results are working as expected.
How I expect reviewers to test this PR
👀
Checklist
Overview of commits