Skip to content

NET-7153 Generate API Gateway CRDs#3506

Merged
sarahalsmiller merged 4 commits intomainfrom
NET-7153-consul-consul-k8s-Create-APIGateway-proto-generate-CRD
Jan 29, 2024
Merged

NET-7153 Generate API Gateway CRDs#3506
sarahalsmiller merged 4 commits intomainfrom
NET-7153-consul-consul-k8s-Create-APIGateway-proto-generate-CRD

Conversation

@sarahalsmiller
Copy link
Copy Markdown
Member

Changes proposed in this PR

  • Generate API Gateway CRDs

How I've tested this PR

  • This is stub work with no logic being added, this PR will be tested as part of additional folow up PRs

How I expect reviewers to test this PR

  • Make sure it looks correct

Checklist

@sarahalsmiller sarahalsmiller added theme/api-gateway Related to Consul API Gateway pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jan 24, 2024
@sarahalsmiller sarahalsmiller requested review from a team, andrewstucki and t-eckert and removed request for a team January 24, 2024 20:07
Copy link
Copy Markdown
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarahalsmiller sarahalsmiller force-pushed the NET-7153-consul-consul-k8s-Create-APIGateway-proto-generate-CRD branch 2 times, most recently from d54f197 to 5f63a53 Compare January 29, 2024 16:21
@sarahalsmiller sarahalsmiller force-pushed the NET-7153-consul-consul-k8s-Create-APIGateway-proto-generate-CRD branch from 5f63a53 to c7e7148 Compare January 29, 2024 18:37
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) January 29, 2024 18:37
@sarahalsmiller sarahalsmiller merged commit 1e67acc into main Jan 29, 2024
@sarahalsmiller sarahalsmiller deleted the NET-7153-consul-consul-k8s-Create-APIGateway-proto-generate-CRD branch January 29, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry theme/api-gateway Related to Consul API Gateway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants