Skip to content

Use golang -alpine image when building go-discover#3501

Merged
curtbushko merged 1 commit intomainfrom
curtbushko/force-build-to-use-arm-v7
Jan 22, 2024
Merged

Use golang -alpine image when building go-discover#3501
curtbushko merged 1 commit intomainfrom
curtbushko/force-build-to-use-arm-v7

Conversation

@curtbushko
Copy link
Contributor

@curtbushko curtbushko commented Jan 22, 2024

Changes proposed in this PR

  • armv6 was deprecated from the base golang docker images for 1.21.x so force golang:-alpine tag instead
  • consul-dataplane already uses the -alpine image.

How I've tested this PR

👀

How I expect reviewers to test this PR

👀

Checklist

@curtbushko curtbushko added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jan 22, 2024
@curtbushko curtbushko force-pushed the curtbushko/force-build-to-use-arm-v7 branch from 3917c3d to 1388be0 Compare January 22, 2024 19:26
@curtbushko curtbushko enabled auto-merge (squash) January 22, 2024 19:30
@curtbushko curtbushko changed the title Use armv7 in golang builds Use golang -alpine image when building go-discover Jan 22, 2024
@curtbushko curtbushko merged commit 54714a4 into main Jan 22, 2024
@curtbushko curtbushko deleted the curtbushko/force-build-to-use-arm-v7 branch January 22, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants