Closed
Conversation
…n with dd specific items as well as additional missing VM based options, unit tests, dd unix socket integration, dd agent acl token generation, deployment override failsafes
…n with dd specific items as well as additional missing VM based options, unit tests, dd unix socket integration, dd agent acl token generation | final initial-push
…e_debug) and telemetry.config update | enable_debug to server.config
Contributor
|
Closing in favour of #3407 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
enable_debugtelemetry.disable_hostnametelemetry.enable_host_metricstelemetry.prefix_filtertelemetry.dogstatsd_addrtelemetry.dogstatsd_tags/v1/agent/metrics?format=prometheusendpoint/v1/agent/metrics?format=prometheus/v1/agent/self/v1/status/leader/v1/status/peers/v1/catalog/services/v1/health/service/v1/health/state/any/v1/coordinate/datacenters/v1/coordinate/nodesserver-acl-inittoken creation for OpenMetrics and Datadog Consul Integration check methods allowing default minimal acl token permission generation for Datadog agent usage as necessary.How I've tested this PR
CONTRIBUTING.mdsteps.consul-dev(main) andconsul-k8s-control-plane-dev(datadog-integration branch) images on k3d test cluster for each scenario. Test repository here.CONTRIBUTING.mdsteps.bats ./charts/consul/test/unit --jobs 8- ran successfully for all tests.How I expect reviewers to test this PR
Checklist