Skip to content

NET-5392 Replace dev dependencies w/ latest release tags#3178

Merged
nathancoleman merged 5 commits intorelease/1.3.0from
NET-5392-remove-dev-deps
Nov 7, 2023
Merged

NET-5392 Replace dev dependencies w/ latest release tags#3178
nathancoleman merged 5 commits intorelease/1.3.0from
NET-5392-remove-dev-deps

Conversation

@nathancoleman
Copy link
Member

Changes proposed in this PR:
Some dependencies were previously pinned to utilize unreleased features of the Consul SDK.
This replaces those with the tagged releases containing those features

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry backport/1.3.x This release branch is no longer active. labels Nov 7, 2023
Copy link
Member

@jm96441n jm96441n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathancoleman nathancoleman added pr/no-backport signals that a PR will not contain a backport label and removed backport/1.3.x This release branch is no longer active. labels Nov 7, 2023
@nathancoleman nathancoleman changed the base branch from main to release/1.3.0 November 7, 2023 20:34
@nathancoleman nathancoleman force-pushed the NET-5392-remove-dev-deps branch from e0a7532 to 3747aae Compare November 7, 2023 20:34
@nathancoleman nathancoleman force-pushed the NET-5392-remove-dev-deps branch from 3747aae to 667d390 Compare November 7, 2023 20:35
JsonFormat: "jsonFormat",
TextFormat: "text format.",
},
EnvoyExtensions: []*pbmesh.EnvoyExtension{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field was intentionally removed in hashicorp/consul#19186.
I've confirmed with @ishustava that it's safe to remove this code from the test.

@nathancoleman nathancoleman merged commit 0f81470 into release/1.3.0 Nov 7, 2023
@nathancoleman nathancoleman deleted the NET-5392-remove-dev-deps branch November 7, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants