Skip to content

add probes now that expose paths are supported#3096

Merged
DanStough merged 1 commit intomainfrom
nd/fix-expose-paths
Oct 19, 2023
Merged

add probes now that expose paths are supported#3096
DanStough merged 1 commit intomainfrom
nd/fix-expose-paths

Conversation

@ndhanushkodi
Copy link
Copy Markdown
Contributor

@ndhanushkodi ndhanushkodi commented Oct 17, 2023

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

ndhanushkodi
ndhanushkodi commented Oct 17, 2023
View reviewed changes
acceptance/tests/mesh_v2/mesh_inject_test.go

helmValues := map[string]string{
"global.experiments[0]": "resource-apis",
"global.image": "ndhanushkodi/consul-dev:expose2",
Copy link
Copy Markdown
Contributor Author

@ndhanushkodi ndhanushkodi Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove this once the change is in the consul image being used here

Copy link
Copy Markdown
Member

@zalimeni zalimeni Oct 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to save you the time checking: hashicorppreview/consul:1.17-dev and hashicorppreview/consul:1.17.0 were published this AM, so I think you're good!

DanStough
DanStough approved these changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DanStough DanStough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a little sus we don't need to make any test changes but the change looks good for now.

@ndhanushkodi
Copy link
Copy Markdown
Contributor Author

ndhanushkodi commented Oct 17, 2023

@DanStough oh yeah, so before making fixes in consul, it the multiport pod wouldn't come up with the probes, so I saw it crashloop, and the fact that it came up and the rest of the test could run means probes are working

@DanStough
Copy link
Copy Markdown
Contributor

DanStough commented Oct 17, 2023

I was thinking of the webhook unit test, but I don't think it's a big deal. :shipit:

@ndhanushkodi
Copy link
Copy Markdown
Contributor Author

ndhanushkodi commented Oct 17, 2023

@DanStough ahhh got it

@ndhanushkodi ndhanushkodi added backport/1.3.x This release branch is no longer active. pr/no-changelog PR does not need a corresponding .changelog entry labels Oct 19, 2023
@DanStough DanStough force-pushed the nd/fix-expose-paths branch from 7a279d9 to 5fa62b8 Compare October 19, 2023 20:08
@DanStough DanStough merged commit 75ed6de into main Oct 19, 2023
@DanStough DanStough deleted the nd/fix-expose-paths branch October 19, 2023 21:57
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Oct 19, 2023
Merged
2 tasks
DanStough pushed a commit that referenced this pull request Oct 19, 2023
@ndhanushkodi @DanStough
add probes now that expose paths are supported (#3096)
3d0da40
@DanStough DanStough mentioned this pull request Oct 19, 2023
Merged
thisisnotashwin pushed a commit that referenced this pull request Oct 20, 2023
@DanStough @ndhanushkodi
add probes now that expose paths are supported (#3096) (#3112)
beda8a2 
Co-authored-by: Nitya Dhanushkodi <nitya@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zalimeni zalimeni Awaiting requested review from zalimeni

2 more reviewers

@DanStough DanStough DanStough approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/1.3.x This release branch is no longer active. pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ndhanushkodi @DanStough @zalimeni @thisisnotashwin