Backport of NET-5531 Translate response header modifier(s) from HTTPRoute onto Consul config entry into release/1.2.x#2951
Closed
hc-github-team-consul-core wants to merge 1 commit intorelease/1.2.xfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
Member
|
Decided not to backport |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2904 to be assessed for backporting due to the inclusion of the label backport/1.2.x.
🚨
The person who merged in the original PR is:
@nathancoleman
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
Translate the
responseHeaderModifierthat already exists on the K8sHTTPRouteonto thehttp-routeconfig entry in Consul, which accepts response header modifiers as of hashicorp/consul#18646.This PR also addresses the fact that we write an empty header modifier to Consul today for request header modifications when the K8s
HTTPRoutedoes not specify any header modifications. Instead, we now appropriately write an empty list of header modifications to Consul when theHTTPRoutedoes not specify any.How I've tested this PR:
Create a K8s
HTTPRoutewith various response header modifier filter(s) and verify that the filter syncs into Consul and functions correctly. See video of my own testing.In addition, conformance tests exist here for this functionality that should pass where they previously failed. Here is the output of those tests passing.

How I expect reviewers to test this PR:
See above
Checklist:
Overview of commits