Merged
Conversation
asheshvidyut
added
pr/no-changelog
Contributor
Author
|
I am updating the bats test now. Please keep go ahead with review. |
added 2 commits
September 11, 2023 22:15
zalimeni
previously approved these changes
Sep 11, 2023
Member
|
@absolutelightning it looks like the original change was backported to |
zalimeni
reviewed
Sep 11, 2023
asheshvidyut
added
backport/1.0.x
backport/1.1.x
Ganeshrockz
approved these changes
Sep 12, 2023
Contributor
Author
|
Acceptance CNI - Partition test is only failing but it is not related to my change. Hence merging the PR since CI is 99% green. |
1 task
This was referenced Sep 12, 2023
asheshvidyut
added a commit
that referenced
this pull request
Sep 12, 2023
* Fix for acceptance tests * fix accpetance test * fix spaces * fix get * added bats test * fix test name * fix bats
asheshvidyut
added a commit
that referenced
this pull request
Sep 12, 2023
* Fix for acceptance tests * fix accpetance test * fix spaces * fix get * added bats test * fix test name * fix bats
asheshvidyut
added a commit
that referenced
this pull request
Sep 12, 2023
* Fix for acceptance tests * fix accpetance test * fix spaces * fix get * added bats test * fix test name * fix bats
1 task
asheshvidyut
added a commit
that referenced
this pull request
Sep 12, 2023
* Fix for acceptance tests * fix accpetance test * fix spaces * fix get * added bats test * fix test name * fix bats
asheshvidyut
added a commit
that referenced
this pull request
Sep 12, 2023
* backport of commit fcb1b3e * Fix for acceptance tests (#2937) * Fix for acceptance tests * fix accpetance test * fix spaces * fix get * added bats test * fix test name * fix bats * fix changes * revert file --------- Co-authored-by: absolutelightning <ashesh.vidyut@hashicorp.com> Co-authored-by: Ashesh Vidyut <134911583+absolutelightning@users.noreply.github.com>
asheshvidyut
added a commit
that referenced
this pull request
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
Ran the test on local.
How I expect reviewers to test this PR:
Checklist: