Backport of Configure Gateway Deployment Resources#2922
Merged
t-eckert merged 1 commit intorelease/1.2.xfrom Sep 7, 2023
Merged
Backport of Configure Gateway Deployment Resources#2922t-eckert merged 1 commit intorelease/1.2.xfrom
t-eckert merged 1 commit intorelease/1.2.xfrom
Conversation
* Update comments on Deployment * Move resources into managedGatewayClass * Add resource configuration to GatewayClassConfig * Regenerate CRDs * Pass resource configuration into the gateway-resources-job * Pull in resources from GatewayClassConfig * Add flag for resources in `gateway-resources` subcommand * Clean up some comments in existing code * Add gateway-resources configmap * Load configmap into gateway-resources job * Load resources from json * Update CRDs * Read resources in from the configmap * Add BATs for Gateway Resources Configmap * Add Changelog * Fix unquoted value in BATs * Fix how resources.json is read * Fix BATs errors for real * Fix seg fault bug * Fix reading of resources file * Quote "$actual" * Fix zsh/sh differences in BATs * Update control-plane/api-gateway/common/helm_config.go Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com> * Move resources into DeploymentSpec * Remove extra split in crds --------- Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
t-eckert
added
pr/no-changelog
david-yu
approved these changes
Sep 7, 2023
nathancoleman
approved these changes
Sep 7, 2023
Member
nathancoleman
left a comment
nathancoleman
left a comment
There was a problem hiding this comment.
Matches the source PR. The slight difference in added lines is due to some copyright headers in files that don't exist in the release/1.2.x branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #2723 into 1.2.x. Replaces #2853