[NET-5399] Improve token fetching performance for endpoints controller.#2920
Merged
hashi-derek merged 3 commits intorelease/1.2.xfrom Sep 11, 2023
Merged
Conversation
Prior to this change, the endpoints controller would list all ACL tokens in a namespace when a service instance is being deleted. This commit improves the performance by querying only the necessary subset of tokens by service-identity / service-name.
hashi-derek
force-pushed
the
derekm/NET-5399/improve-token-fetch-1.2
branch
from
5d25270 to
83a1b5b
Compare
hashi-derek
added
the
pr/no-backport
curtbushko
approved these changes
Sep 8, 2023
wilkermichael
approved these changes
Sep 8, 2023
hashi-derek
changed the title
hashi-derek
added
the
pr/no-changelog
wilkermichael
suggested changes
Sep 8, 2023
Contributor
wilkermichael
left a comment
wilkermichael
left a comment
There was a problem hiding this comment.
Do we need a changelog here?
wilkermichael
approved these changes
Sep 8, 2023
Contributor
wilkermichael
left a comment
wilkermichael
left a comment
There was a problem hiding this comment.
Thanks for the changelog
Contributor
Author
|
You caught it at the same time I did @wilkermichael |
Contributor
|
Yeah, I thought that latency was unreal 😆 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #2910