Skip to content

Backport of Fix audit log parse error into release/1.0.x#2916

Merged
hc-github-team-consul-core merged 4 commits intorelease/1.0.xfrom
backport/net-5513/fix-integer/formerly-clear-stag
Sep 8, 2023
Merged

Backport of Fix audit log parse error into release/1.0.x#2916
hc-github-team-consul-core merged 4 commits intorelease/1.0.xfrom
backport/net-5513/fix-integer/formerly-clear-stag

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #2905 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Fixes a bug in parsing the following audit log helm configuration
server:
  auditLogs:
      enabled: true
      sinks:
        - name: My Sink
          type: file
          format: json
          path: /tmp/audit.json
          delivery_guarantee: best-effort
          rotate_duration: 24h
          rotate_max_files: 15
          rotate_bytes: 25165824

where rotate_max_files and rotate_bytes get passed as string inputs to the server configuration file. This PR makes sure to perform special handling for rotate_max_files and rotate_bytes where they don't get passed with quotes.

Generated config (Before the fix)

    {
      "audit": {
        "enabled": true,
        "sink": {
          "MySink": {
              "delivery_guarantee": "best-effort",
              "format": "json",
              "path": "/tmp/audit.json",
              "rotate_bytes": "12455355", // note the presence of braces here
              "rotate_duration": "24h",
              "rotate_max_files": "20",
              "type": "file"
          }
        }
      }
    }

Generated config (After the fix)

    {
      "audit": {
        "enabled": true,
        "sink": {
          "MySink": {
              "delivery_guarantee": "best-effort",
              "format": "json",
              "path": "/tmp/audit.json",
              "rotate_bytes": 12455355, // note the absence of braces here
              "rotate_duration": "24h",
              "rotate_max_files": 20,
              "type": "file"
          }
        }
      }
    }

How I've tested this PR:

  1. CI
  2. Verified manually that the server no longer crashes with this issue.

How I expect reviewers to test this PR:

👀

Checklist:


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/net-5513/fix-integer/formerly-clear-stag branch from 8e3602b to 10bcb7c Compare September 7, 2023 04:10
@Ganeshrockz Ganeshrockz requested a review from david-yu September 7, 2023 13:45
@Ganeshrockz Ganeshrockz added the pr/no-backport signals that a PR will not contain a backport label label Sep 8, 2023
@hc-github-team-consul-core hc-github-team-consul-core merged commit 11df69e into release/1.0.x Sep 8, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/net-5513/fix-integer/formerly-clear-stag branch September 8, 2023 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants