[NET-5346] Expose JWKCluster fields in jwt-provider config entry#2881
Merged
roncodingenthusiast merged 1 commit intomainfrom Sep 14, 2023
Merged
[NET-5346] Expose JWKCluster fields in jwt-provider config entry#2881roncodingenthusiast merged 1 commit intomainfrom
roncodingenthusiast merged 1 commit intomainfrom
Conversation
roncodingenthusiast
force-pushed
the
NET-5346
branch
from
e54e088 to
0671ffa
Compare
roncodingenthusiast
added
the
backport/1.2.x
roncodingenthusiast
changed the title
roncodingenthusiast
requested review from
a team,
kisunji and
skpratt
and removed request for
a team
roncodingenthusiast
changed the title
roncodingenthusiast
force-pushed
the
NET-5346
branch
from
0671ffa to
595fa64
Compare
roncodingenthusiast
force-pushed
the
NET-5346
branch
from
595fa64 to
8e93bcb
Compare
roncodingenthusiast
changed the title
roncodingenthusiast
force-pushed
the
NET-5346
branch
2 times, most recently
from
ae7f87d to
e2e7ddc
Compare
kisunji
reviewed
Sep 6, 2023
kisunji
reviewed
Sep 6, 2023
kisunji
reviewed
Sep 6, 2023
kisunji
reviewed
Sep 6, 2023
kisunji
reviewed
Sep 6, 2023
kisunji
reviewed
Sep 6, 2023
Contributor
kisunji
left a comment
kisunji
left a comment
There was a problem hiding this comment.
Just one recurring comment about json tags but the rest look good.
I think you may be missing an update to the deepcopy function (I had one in my PR but forgot what generated it 🤔 )
roncodingenthusiast
force-pushed
the
NET-5346
branch
from
a4281c6 to
3f0338b
Compare
roncodingenthusiast
force-pushed
the
NET-5346
branch
2 times, most recently
from
d4c918b to
027730c
Compare
wilkermichael
approved these changes
Sep 12, 2023
Contributor
wilkermichael
left a comment
wilkermichael
left a comment
There was a problem hiding this comment.
Great work here! Some really minor comments
Thanks for testing this locally as well :D
roncodingenthusiast
force-pushed
the
NET-5346
branch
from
6df72e3 to
a5a62cc
Compare
roncodingenthusiast
force-pushed
the
NET-5346
branch
from
a5a62cc to
63bba27
Compare
kisunji
approved these changes
Sep 13, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
How I expect reviewers to test this PR:
TODO: