Skip to content

Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1.x#2873

Merged
asheshvidyut merged 1 commit intorelease/1.1.xfrom
NET-5229-1.1.x
Aug 31, 2023
Merged

Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1.x#2873
asheshvidyut merged 1 commit intorelease/1.1.xfrom
NET-5229-1.1.x

Conversation

@asheshvidyut
Copy link
Copy Markdown
Contributor

Changes proposed in this PR:

  • Add support for global.argocd.enabled flag in values.yaml which adds the
        "argocd.argoproj.io/hook": "Sync"
        "argocd.argoproj.io/hook-delete-policy": "HookSucceeded"

in the jobs -
server-acl-init-job

How I've tested this PR:

demoargocd.mov

Checklist:

* enable argocd

* adds bats test and setting argo annotations if global.argocd.enabled = true

* update comment

* added change log

* Update charts/consul/templates/gateway-cleanup-job.yaml

Co-authored-by: Ganesh S <ganesh.seetharaman@hashicorp.com>

* comments fixes

* fix line diff

* change log fix

* fix comment

* Update .changelog/2785.txt

Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>

---------

Co-authored-by: Ganesh S <ganesh.seetharaman@hashicorp.com>
Co-authored-by: Luke Kysow <1034429+lkysow@users.noreply.github.com>
@asheshvidyut asheshvidyut changed the title Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1x Backport - Net 5229 create dedicated argocd stanza (#2785) in release 1.1.x Aug 31, 2023
@asheshvidyut asheshvidyut added the pr/no-backport signals that a PR will not contain a backport label label Aug 31, 2023
@asheshvidyut asheshvidyut enabled auto-merge (squash) August 31, 2023 06:29
@asheshvidyut asheshvidyut merged commit 21faa89 into release/1.1.x Aug 31, 2023
@asheshvidyut asheshvidyut deleted the NET-5229-1.1.x branch August 31, 2023 06:42
@asheshvidyut asheshvidyut added the consul-india PRs/Issues assigned to Consul India team label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consul-india PRs/Issues assigned to Consul India team pr/no-backport signals that a PR will not contain a backport label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants