docs - Update connectInject.logLevel docs#2871
Merged
Conversation
david-yu
added
backport/1.0.x
backport/1.1.x
asheshvidyut
approved these changes
Aug 31, 2023
david-yu
added
the
pr/no-changelog
boruszak
approved these changes
Aug 31, 2023
Contributor
boruszak
left a comment
boruszak
left a comment
There was a problem hiding this comment.
LGTM!
Really minor suggestions to help align with the style guide. Flagging that there is a decision for you to make, whether you prefer to use logLevel or log level - definitely an edge case where either would work.
Approving on behalf of consul-docs.
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
consul-dataplanesidecar andconsul-connect-inject-initcontainer.How I've tested this PR:
How I expect reviewers to test this PR:
Checklist: