Backport of Adds fields for PassiveHealthCheck on IngressGateway into release/1.0.x#2858
Merged
missylbytes merged 1 commit intorelease/1.0.xfrom Aug 30, 2023
Merged
Conversation
fa82aec to
def3136
Compare
…iceDefault CRDs (#2796) Co-authored-by: Andrew Stucki <andrew.stucki@hashicorp.com>
def3136 to
051071c
Compare
missylbytes
approved these changes
Aug 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2796 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
🚨
The person who merged in the original PR is:
@missylbytes
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Changes proposed in this PR:
How I've tested this PR:
Install Consul locally with the following values:
Running kubectl apply on the following IngressGateway configuration:
The apply should succeed and you should be able to see the PassiveHealthCheck configured correctly in Consul:
consul config read -kind ingress-gateway -name ingress-gatewayHow I expect reviewers to test this PR:
Checklist:
Overview of commits