Skip to content

Backport of Set privileged to false unless on OpenShift without CNI into release/1.2.x#2763

Merged
hc-github-team-consul-core merged 2 commits intorelease/1.2.xfrom
backport/privileged-false/incredibly-one-terrier
Aug 11, 2023
Merged

Backport of Set privileged to false unless on OpenShift without CNI into release/1.2.x#2763
hc-github-team-consul-core merged 2 commits intorelease/1.2.xfrom
backport/privileged-false/incredibly-one-terrier

Conversation

@hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #2755 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Sets privileged=false for regular transparent proxy connect injects
  • Also false when CNI is used
  • True for OpenShift with transparent proxy

How I've tested this PR:

  • unit tests and accpetance, manual tests on OpenShift

How I expect reviewers to test this PR:

👀

Checklist:


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/privileged-false/incredibly-one-terrier branch from 7946efd to 02d9ca8 Compare August 11, 2023 18:30
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/privileged-false/incredibly-one-terrier branch from fbd996b to 6de4c55 Compare August 11, 2023 18:30
@hc-github-team-consul-core hc-github-team-consul-core merged commit 251ed18 into release/1.2.x Aug 11, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/privileged-false/incredibly-one-terrier branch August 11, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants