Skip to content

Backport of NET-5104 envoy port mapping into release/1.2.x#2739

Merged
nathancoleman merged 1 commit intorelease/1.2.xfrom
backport/net-5104-envoy-port-mapping/supposedly-refined-mutt
Aug 8, 2023
Merged

Backport of NET-5104 envoy port mapping into release/1.2.x#2739
nathancoleman merged 1 commit intorelease/1.2.xfrom
backport/net-5104-envoy-port-mapping/supposedly-refined-mutt

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Aug 8, 2023 •
edited by nathancoleman
Loading

Backport

This PR is auto-generated from #2707 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.

Changes proposed in this PR:

  • When a user creates a gateway with mapPrivilegedContainerPorts set, we add that value to any privileged container ports they define on their gateways.

How I've tested this PR:
Deploy on GKE with a gateway listener having port 80 and the mapPrivilegedContainerPorts value set.

#Example values.yaml with managedGatewayClass mapPrivilegedContainerPorts set.
connectInject:
  apiGateway:
    managedGatewayClass:
      mapPrivilegedContainerPorts: 2000

How I expect reviewers to test this PR:
Tests

Checklist:

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/net-5104-envoy-port-mapping/supposedly-refined-mutt branch 2 times, most recently from 4a40cbc to bd717ab Compare August 8, 2023 14:48
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/net-5104-envoy-port-mapping/supposedly-refined-mutt branch from 0320911 to bd717ab Compare August 8, 2023 14:48
@missylbytes @nathancoleman
Gateway privileged port mapping (#2707)
197d923 
* Adds port mapping to Gateway Class Config to avoid running container on privileged ports

Co-authored-by: Nathan Coleman <nathan.coleman@hashicorp.com>
@nathancoleman nathancoleman force-pushed the backport/net-5104-envoy-port-mapping/supposedly-refined-mutt branch from bd717ab to 197d923 Compare August 8, 2023 14:56
@nathancoleman nathancoleman marked this pull request as ready for review August 8, 2023 15:01
nathancoleman
nathancoleman approved these changes Aug 8, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches source PR

@nathancoleman nathancoleman enabled auto-merge (squash) August 8, 2023 15:02
@nathancoleman nathancoleman merged commit c7d27f4 into release/1.2.x Aug 8, 2023
@nathancoleman nathancoleman deleted the backport/net-5104-envoy-port-mapping/supposedly-refined-mutt branch August 8, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathancoleman nathancoleman nathancoleman approved these changes

@missylbytes missylbytes Awaiting requested review from missylbytes

Assignees

@missylbytes missylbytes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hc-github-team-consul-core @nathancoleman @missylbytes