Manual backport of [NET-5146] security: Upgrade Go and x/net into release/1.0.x#2722
Merged
zalimeni merged 2 commits intorelease/1.0.xfrom Aug 4, 2023
Conversation
Upgrade to Go 1.19.12 and `x/net` 1.13.0 to resolve [CVE-2023-29409](https://nvd.nist.gov/vuln/detail/CVE-2023-29409) and [CVE-2023-3978](https://nvd.nist.gov/vuln/detail/CVE-2023-3978).
This was a manually backported change due to differences in Go versions (1.20 vs. 1.19), which should also be reflected in the backported changelog. As a result, alter that changelog file to point to the manual backport PR directly.
zalimeni
commented
Aug 3, 2023
Comment on lines
1
to
4
| ```release-note:security | ||
| Upgrade to use Go 1.20.6 and `x/net/http` 0.12.0. | ||
| Upgrade to use Go 1.19.11 and `x/net/http` 0.12.0. | ||
| This resolves [CVE-2023-29406](https://github.com/advisories/GHSA-f8f7-69v5-w4vx)(`net/http`). | ||
| ``` |
Member
Author
There was a problem hiding this comment.
Corrected changelog from previous bump PR #2650
zalimeni
added
the
pr/no-backport
curtbushko
approved these changes
Aug 3, 2023
picatz
approved these changes
Aug 3, 2023
Member
Author
|
Spent several hours trying to get this to pass, but it seems we have some persistent flaking in the CNI partitions acceptance test. Given the low risk of this change, I'm going to merge and follow up on that breakage separately. |
zalimeni
deleted the
backport/zalimeni/net-5146-bump-go-net_http-cve/manual-1.0.x
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport (different Go version) of #2710, replaces #2712
Upgrade to Go 1.19.12 and
net/http1.13.0 to resolve CVE-2023-29409 and CVE-2023-3978.Also, correct the changelog of the previous bump, which did not account for the Go version difference.
How I've tested this PR: tests continue to pass
How I expect reviewers to test this PR: 👀
Checklist: