Add support for requestTimeout in Service Resolver spec (#2641)#2660
Merged
thisisnotashwin merged 1 commit intorelease/1.2.xfrom Jul 26, 2023
Merged
Add support for requestTimeout in Service Resolver spec (#2641)#2660thisisnotashwin merged 1 commit intorelease/1.2.xfrom
thisisnotashwin merged 1 commit intorelease/1.2.xfrom
Conversation
Contributor
thisisnotashwin
commented
Jul 25, 2023
thisisnotashwin
commented
- Add support for requestTimeout in Service Resolver spec
- preserve serviceresolvers.yaml Preserving yaml from main, only adding requesttimeout property.
- update generated.deepcopy.go
- Use latest controller-gen to generate CRDs
thisisnotashwin
added
pr/no-changelog
thisisnotashwin
force-pushed
the
ashwin/add-request-timeout
branch
from
d08e0c6 to
825f6a6
Compare
david-yu
approved these changes
Jul 25, 2023
* Add support for requestTimeout in Service Resolver spec * preserve serviceresolvers.yaml Preserving yaml from main, only adding requesttimeout property. * update generated.deepcopy.go * Use latest controller-gen to generate CRDs --------- Co-authored-by: Ashwin Venkatesh <ashwin.what@gmail.com>
thisisnotashwin
force-pushed
the
ashwin/add-request-timeout
branch
from
825f6a6 to
0d38e99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.