Backport of Increase golangci-lint timeout to 10m into release/1.0.x#2628
Merged
hc-github-team-consul-core merged 1 commit intorelease/1.0.xfrom Jul 21, 2023
Conversation
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/golangci-lint-increase-timeout/vigorously-enough-stinkbug
branch
from
dd250f1 to
6043dfb
Compare
hc-github-team-consul-core
force-pushed
the
backport/zalimeni/golangci-lint-increase-timeout/vigorously-enough-stinkbug
branch
from
21b87e9 to
818efb0
Compare
zalimeni
approved these changes
Jul 21, 2023
hc-github-team-consul-core
deleted the
backport/zalimeni/golangci-lint-increase-timeout/vigorously-enough-stinkbug
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2621 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
The below text is copied from the body of the original PR.
This is meant to solve for recurrent timeouts in several steps, particularly
golangci-lint-control-planeandgolang-ci-lint-cli.An accompanying change in
consul-k8s-workflowsshould disable caching until the (unclear) root of the issue can be resolved, or we can disable or clear cache in a more targeted way that solves for these cases.Note from @DanStough : we've also done this in
consul#2621
hashicorp/consul#17459
Changes proposed in this PR:
golangci-lintcachingHow I've tested this PR:
How I expect reviewers to test this PR: 👀
Checklist:
Overview of commits