Skip to content

Backport of added make target for checking for hashicorppreview into release/1.2.x#2625

Merged
hc-github-team-consul-core merged 2 commits intorelease/1.2.xfrom
backport/mw/add-check-hashicorppreview/intensely-shining-quail
Jul 21, 2023
Merged

Backport of added make target for checking for hashicorppreview into release/1.2.x#2625
hc-github-team-consul-core merged 2 commits intorelease/1.2.xfrom
backport/mw/add-check-hashicorppreview/intensely-shining-quail

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #2603 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Adds a make target to check for hashicorppreview images in the charts. This will help verify release steps.

How I've tested this PR:

Example output where hashicorppreview is found

$ make check-preview-containers
./charts/consul/Chart.yaml:19:      image: docker.mirror.hashicorp.services/hashicorppreview/consul-enterprise:1.17-dev
./charts/consul/Chart.yaml:21:      image: docker.mirror.hashicorp.services/hashicorppreview/consul-k8s-control-plane:1.3.0-dev
./charts/consul/Chart.yaml:23:      image: docker.mirror.hashicorp.services/hashicorppreview/consul-dataplane:1.3-dev
./charts/consul/values.yaml:69:  image: docker.mirror.hashicorp.services/hashicorppreview/consul:1.17-dev
./charts/consul/values.yaml:89:  imageK8S: docker.mirror.hashicorp.services/hashicorppreview/consul-k8s-control-plane:1.3.0-dev
./charts/consul/values.yaml:611:  imageConsulDataplane: docker.mirror.hashicorp.services/hashicorppreview/consul-dataplane:1.3-dev
charts contain hashicorppreview images

Example output where hashicorppreview is not found

$ make check-preview-containers
charts do not contain hashicorpreview images

How I expect reviewers to test this PR:

Checklist:


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/mw/add-check-hashicorppreview/intensely-shining-quail branch from 54fec7b to fcebd58 Compare July 21, 2023 16:48
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/mw/add-check-hashicorppreview/intensely-shining-quail branch from fe05e7e to 4307717 Compare July 21, 2023 16:48
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) July 21, 2023 16:48
@hc-github-team-consul-core hc-github-team-consul-core merged commit 7fcd5a5 into release/1.2.x Jul 21, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/mw/add-check-hashicorppreview/intensely-shining-quail branch July 21, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants