Backport of Handle errors properly when services are de-registered from the catalog into release/1.0.x#2611
Merged
hc-github-team-consul-core merged 2 commits intorelease/1.0.xfrom Jul 20, 2023
Conversation
efb5e86 to
2e7eb14
Compare
225102a to
fd287a3
Compare
curtbushko
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #2571 to be assessed for backporting due to the inclusion of the label backport/1.0.x.
The below text is copied from the body of the original PR.
Possible fix for:
#2085
#2065
hashicorp/consul#15908
#1935
#1817
which are all the same issue of ghost services left in the catalog when nodes are recycled.
Associated issue: #2491
Changes proposed in this PR:
How I've tested this PR:
kubectl delete node+docker stop <image>.docker start <image>will re-register the node.How I expect reviewers to test this PR:
👀
Checklist:
Overview of commits