Skip to content

Backport of api-gateway: Fix nil pointer exception panic into release/1.2.x#2493

Merged
sarahalsmiller merged 4 commits intorelease/1.2.xfrom
backport/bug/nil-pointer-request-header-modifier/possibly-united-shad
Jun 30, 2023
Merged

Backport of api-gateway: Fix nil pointer exception panic into release/1.2.x#2493
sarahalsmiller merged 4 commits intorelease/1.2.xfrom
backport/bug/nil-pointer-request-header-modifier/possibly-united-shad

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #2487 to be assessed for backporting due to the inclusion of the label backport/1.2.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@nathancoleman
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul-k8s/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • Fix nil pointer exception thrown whenever the user uses an httpfilter that does not have RequestHeaderModifier set.

How I've tested this PR:

  • Created unit test that replicated the error and saw that it is resolved with this fix

How I expect reviewers to test this PR:

  • Unit tests pass

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/bug/nil-pointer-request-header-modifier/possibly-united-shad branch 2 times, most recently from 5188816 to ae2487f Compare June 29, 2023 14:54
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/bug/nil-pointer-request-header-modifier/possibly-united-shad branch from ae2487f to 5188816 Compare June 29, 2023 14:54
@sarahalsmiller sarahalsmiller marked this pull request as ready for review June 29, 2023 15:02
@sarahalsmiller sarahalsmiller enabled auto-merge (squash) June 29, 2023 15:16
@sarahalsmiller sarahalsmiller force-pushed the backport/bug/nil-pointer-request-header-modifier/possibly-united-shad branch from 5188816 to a9b69f9 Compare June 30, 2023 15:21
@sarahalsmiller sarahalsmiller merged commit f0c87b8 into release/1.2.x Jun 30, 2023
@sarahalsmiller sarahalsmiller deleted the backport/bug/nil-pointer-request-header-modifier/possibly-united-shad branch June 30, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants