Skip to content

[release/1.2.0] Backport api-gateway: Fix nil pointer exception panic#2489

Merged
nathancoleman merged 2 commits intorelease/1.2.0from
backport/bug/nil-pointer-request-header-modifier
Jun 29, 2023
Merged

[release/1.2.0] Backport api-gateway: Fix nil pointer exception panic#2489
nathancoleman merged 2 commits intorelease/1.2.0from
backport/bug/nil-pointer-request-header-modifier

Conversation

@nathancoleman
Copy link
Copy Markdown
Member

@nathancoleman nathancoleman commented Jun 28, 2023

Changes proposed in this PR:
This is a backport of #2487 targeting the 1.2.0 release

How I've tested this PR:
🤖 tests

How I expect reviewers to test this PR:
🤖 tests

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@nathancoleman nathancoleman added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels Jun 28, 2023
@nathancoleman nathancoleman changed the title [release/1.2.0] Backport/bug/nil pointer request header modifier [release/1.2.0] Backport api-gateway: Fix nil pointer exception panic Jun 28, 2023
@nathancoleman nathancoleman requested review from david-yu and removed request for t-eckert June 28, 2023 23:19
@NicoletaPopoviciu
Copy link
Copy Markdown
Collaborator

@nathancoleman original PR had changes in 3 files

@nathancoleman
Copy link
Copy Markdown
Member Author

@NicoletaPopoviciu the original PR has changes to a test that doesn't exist in this branch.

I think I'm about to remove those changes from the original PR anyways but wanted to let ya know

@nathancoleman nathancoleman merged commit a732565 into release/1.2.0 Jun 29, 2023
@nathancoleman nathancoleman deleted the backport/bug/nil-pointer-request-header-modifier branch June 29, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants